Tracking Search API Calls #18601
Tracking Search API Calls #18601
Conversation
Signed-off-by: Anthony Leong <[email protected]>
github-actions
bot
added
enhancement
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for c5aeb69: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for ff3d106: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 3dae11a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 333c59f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for b0c64dc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
ajleong623
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326 and
kotwanikunal
as code owners
ajleong623
requested review from
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah and
a team
as code owners
|
❌ Gradle check result for 68c0351: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for eea8dbe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Any ideas on how to handle the breaking changes? I had to refactor chunks of code and relocate parts of the api. |
|
@jainankitk , @sgup432 can you take a look at this and advise? @ajleong623 I think you might need to rebase your PR since I see a lot of commits unrelated to your work. That will hopefully reduce the actual number of changes to review. |
|
❌ Gradle check result for 8bfed6c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for 99ddb3d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for c368a4b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@kkhatua It seems like the deadline for 3.2.0 is coming up. Will the pr be able to make that? |
Signed-off-by: Anthony Leong <[email protected]>
|
❌ Gradle check result for d1b22f5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@kkhatua I will be closing this pull request in favor of #19115. I did this to clean up the breaking changes and make sure I am updating from an up-to-date branch. I believe my changes are ready for review. The core details are the same as this pull request, so you can still refer here if you have any questions. |
Description
This change will create a tracker for all the search API calls inside of the search object in the indices statistics of the node stats API. When there is an
_msearchcall, there can be partial failures, and this tracker will be able to catch those even though_msearchmight still return a 200 response.Related Issues
Resolves #18377, #18438
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.